Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show selected audio device indicator in header for mweb #2053

Merged
merged 12 commits into from
Oct 31, 2023
Merged

feat: show selected audio device indicator in header for mweb #2053

merged 12 commits into from
Oct 31, 2023

Conversation

amar-1995
Copy link
Contributor

No description provided.

@amar-1995 amar-1995 requested a review from raviteja83 as a code owner October 19, 2023 01:14
@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 1:37pm
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 1:37pm

@amar-1995 amar-1995 requested a review from raviteja83 October 20, 2023 05:48
@amar-1995 amar-1995 requested a review from raviteja83 October 20, 2023 07:17
raviteja83
raviteja83 requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@raviteja83 raviteja83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how much effort would it be to convert this to tsx? can we check once. if there are not too many errors, let's do it.

packages/roomkit-react/src/Prebuilt/components/Header/common.jsx Outdated Show resolved Hide resolved
packages/roomkit-react/src/Prebuilt/components/Header/common.jsx Outdated Show resolved Hide resolved
packages/roomkit-react/src/Prebuilt/components/Header/common.jsx Outdated Show resolved Hide resolved
packages/roomkit-react/src/Prebuilt/components/Header/common.jsx Outdated Show resolved Hide resolved
@raviteja83 raviteja83 changed the title feat: selected audio output device icon on header feat: show selected audio device indicator in header for mweb Oct 31, 2023
@raviteja83 raviteja83 merged commit f015c57 into dev Oct 31, 2023
4 checks passed
@raviteja83 raviteja83 deleted the WEB-2283-audio-output-show-selected-device-icon branch October 31, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviteja83 raviteja83 raviteja83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amar-1995 @raviteja83